Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: respect inflection rules, humanize instead capitalize #1861

Merged
merged 1 commit into from
Jul 24, 2023

Conversation

Paul-Bob
Copy link
Contributor

Description

Avo was wrongly capitalizing resource names ignoring the acronyms configured on the inflections.rb

We start using humanize instead capitalize in many places in order to fix this issue.

Fixes #1858

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@Paul-Bob Paul-Bob added the Fix label Jul 24, 2023
@Paul-Bob Paul-Bob self-assigned this Jul 24, 2023
@codeclimate
Copy link

codeclimate bot commented Jul 24, 2023

Code Climate has analyzed commit cbecfe8 and detected 0 issues on this pull request.

View more on Code Climate.

@Paul-Bob Paul-Bob merged commit 5c06f54 into main Jul 24, 2023
14 checks passed
@Paul-Bob Paul-Bob deleted the fix/respect_inflection_rules branch July 24, 2023 12:18
@github-actions
Copy link
Contributor

This PR has been merged into main. The functionality will be available in the next release.

Please check the release guide for more information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resource titles on index pages are not respecting Rails inflection rules.
2 participants