Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: filter tests #187

Merged
merged 7 commits into from Nov 30, 2020
Merged

fix: filter tests #187

merged 7 commits into from Nov 30, 2020

Conversation

mihaimdm22
Copy link
Contributor

hope to work this time

@mihaimdm22 mihaimdm22 added the Fix label Nov 14, 2020
@codecov
Copy link

codecov bot commented Nov 14, 2020

Codecov Report

Merging #187 (c483c4c) into master (8a13028) will increase coverage by 0.90%.
The diff coverage is 94.35%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #187      +/-   ##
==========================================
+ Coverage   96.03%   96.93%   +0.90%     
==========================================
  Files          87      134      +47     
  Lines        1890     3781    +1891     
==========================================
+ Hits         1815     3665    +1850     
- Misses         75      116      +41     
Impacted Files Coverage Δ
lib/avo/app/tools_manager.rb 50.00% <50.00%> (ø)
spec/dummy/app/policies/user_policy.rb 56.25% <53.33%> (ø)
lib/avo/app/action.rb 80.48% <80.48%> (ø)
lib/avo/engine.rb 85.71% <85.71%> (ø)
lib/avo/app/fields/boolean_field.rb 93.75% <87.50%> (ø)
lib/avo/app/app.rb 89.70% <89.70%> (ø)
lib/avo/app/fields/key_value_field.rb 90.90% <90.90%> (ø)
app/controllers/avo/resources_controller.rb 91.45% <91.45%> (ø)
.../avo/app/fields/field_extensions/has_field_name.rb 91.66% <91.66%> (ø)
spec/dummy/app/avo/filters/published_filter.rb 91.66% <91.66%> (ø)
... and 179 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb9c252...c483c4c. Read the comment docs.

@mihaimdm22 mihaimdm22 merged commit 2cb6abd into master Nov 30, 2020
@mihaimdm22 mihaimdm22 deleted the fix/filter-tests branch November 30, 2020 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant