Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: action redirect allow_other_host and status arguments & actions turbo attribute #1878

Merged
merged 2 commits into from
Aug 1, 2023

Conversation

Paul-Bob
Copy link
Contributor

@Paul-Bob Paul-Bob commented Aug 1, 2023

Description

Fixes #1761 , #1877

Action's redirect_to method now accepts allow_other_host and status arguments.
It's also possible to turn turbo to false using the self.turbo = false action configuration, this is useful for external redirects for example.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@Paul-Bob Paul-Bob self-assigned this Aug 1, 2023
@codeclimate
Copy link

codeclimate bot commented Aug 1, 2023

Code Climate has analyzed commit 3485f64 and detected 0 issues on this pull request.

View more on Code Climate.

@Paul-Bob Paul-Bob merged commit 53f765f into main Aug 1, 2023
13 checks passed
@Paul-Bob Paul-Bob deleted the feature/actions_redirect_to_external_links branch August 1, 2023 10:17
@github-actions
Copy link
Contributor

github-actions bot commented Aug 1, 2023

This PR has been merged into main. The functionality will be available in the next release.

Please check the release guide for more information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Turbo interfering with action redirects.
1 participant