Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Added check for tailwind.config.js based on its path #1764 #1891

Merged
merged 2 commits into from
Sep 26, 2023

Conversation

sarvaiyanidhi
Copy link
Contributor

Description

Added check to fix issue of showing instruction based on the path of tailwind.config.js file and append the -c ./config/tailwind.config.js to the instructions.

Fixes #1764

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

Manual review steps

  1. Tested code by running bin/rails generate avo:tailwindcss:install command for dummy project
  2. If we have tailwind.config.js in spec/dummy/config/tailwind.config.js path we get instruction as
    "scripts": { "avo:tailwindcss": "tailwindcss -i ./app/assets/stylesheets/avo.tailwind.css -o ./app/assets/builds/avo.tailwind.css -c ./config/tailwind.config.js" --minify }
  3. If we don't have file in config directory we get instruction as
    "scripts": { "avo:tailwindcss": "tailwindcss -i ./app/assets/stylesheets/avo.tailwind.css -o ./app/assets/builds/avo.tailwind.css" --minify }

@codeclimate
Copy link

codeclimate bot commented Aug 10, 2023

Code Climate has analyzed commit a769344 and detected 0 issues on this pull request.

View more on Code Climate.

@github-actions
Copy link
Contributor

This PR has been marked as stale because there was no activity for the past 15 days.

@github-actions github-actions bot added the Stale label Aug 26, 2023
@github-actions
Copy link
Contributor

Closing this because there was no activity for the past 15 days. Feel free to reopen if new information pops up ✌️

@adrianthedev
Copy link
Collaborator

@Paul-Bob could you please test and merge this? Thank you!

@github-actions github-actions bot removed the Stale label Sep 11, 2023
@github-actions
Copy link
Contributor

This PR has been marked as stale because there was no activity for the past 15 days.

@github-actions github-actions bot added the Stale label Sep 26, 2023
@Paul-Bob Paul-Bob removed the Stale label Sep 26, 2023
Copy link
Contributor

@Paul-Bob Paul-Bob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for submitting this PR @sarvaiyanidhi

I tested it and works as expected @adrianthedev

@Paul-Bob Paul-Bob merged commit 3ada139 into avo-hq:main Sep 26, 2023
19 checks passed
@Paul-Bob Paul-Bob added the Fix label Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tailwind install process lists incomplete package script entry
3 participants