New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: loaders are not visible on some pages #190
Conversation
lib/avo/app/resource.rb
Outdated
@@ -13,7 +13,15 @@ class Resource | |||
|
|||
class << self | |||
def hydrate_resource(model:, resource:, view: :index, user:) | |||
default_panel_name = I18n.t 'avo.resource_details', name: resource.name | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[rubocop] reported by reviewdog 🐶
Layout/EmptyLinesAroundMethodBody: Extra empty line detected at method body beginning.
Codecov Report
@@ Coverage Diff @@
## master #190 +/- ##
==========================================
+ Coverage 96.03% 96.64% +0.61%
==========================================
Files 87 133 +46
Lines 1890 3668 +1778
==========================================
+ Hits 1815 3545 +1730
- Misses 75 123 +48
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Loader has different top margins.
Loaders on
new
,show
andcreate
views are not visible. This fixes that