Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: loaders are not visible on some pages #190

Merged
merged 4 commits into from Nov 25, 2020

Conversation

adrianthedev
Copy link
Collaborator

Loaders on new, show and create views are not visible. This fixes that

loaders not visible

@@ -13,7 +13,15 @@ class Resource

class << self
def hydrate_resource(model:, resource:, view: :index, user:)
default_panel_name = I18n.t 'avo.resource_details', name: resource.name

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[rubocop] reported by reviewdog 🐶
Layout/EmptyLinesAroundMethodBody: Extra empty line detected at method body beginning.

@codecov
Copy link

codecov bot commented Nov 20, 2020

Codecov Report

Merging #190 (7529da0) into master (8a13028) will increase coverage by 0.61%.
The diff coverage is 93.80%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #190      +/-   ##
==========================================
+ Coverage   96.03%   96.64%   +0.61%     
==========================================
  Files          87      133      +46     
  Lines        1890     3668    +1778     
==========================================
+ Hits         1815     3545    +1730     
- Misses         75      123      +48     
Impacted Files Coverage Δ
lib/avo/app/tools_manager.rb 50.00% <50.00%> (ø)
lib/avo/app/action.rb 80.48% <80.48%> (ø)
lib/avo/engine.rb 85.71% <85.71%> (ø)
lib/avo/app/fields/boolean_field.rb 93.75% <87.50%> (ø)
lib/avo/app/app.rb 89.18% <89.18%> (ø)
lib/avo/app/resource.rb 90.35% <90.35%> (ø)
app/controllers/avo/resources_controller.rb 90.59% <90.59%> (ø)
lib/avo/app/fields/key_value_field.rb 90.90% <90.90%> (ø)
.../avo/app/fields/field_extensions/has_field_name.rb 91.66% <91.66%> (ø)
...lds/field_extensions/visible_in_different_views.rb 92.85% <92.85%> (ø)
... and 175 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a85e7c...7529da0. Read the comment docs.

Copy link
Contributor

@mihaimdm22 mihaimdm22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Loader has different top margins.

@adrianthedev
Copy link
Collaborator Author

adrianthedev commented Nov 25, 2020

I fixed that by displaying the filters and search bar. This way it is larger on Index but looks natural.

@adrianthedev adrianthedev merged commit 4086d43 into master Nov 25, 2020
@adrianthedev adrianthedev deleted the fix/loaders-not-visible-on-some-pages branch November 25, 2020 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants