Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: Added new badge 'secondary' for option like drafting #1912

Merged
merged 4 commits into from
Aug 16, 2023
Merged

feature: Added new badge 'secondary' for option like drafting #1912

merged 4 commits into from
Aug 16, 2023

Conversation

sarvaiyanidhi
Copy link
Contributor

@sarvaiyanidhi sarvaiyanidhi commented Aug 16, 2023 •
edited

Description

This PR addresses the feature requirement for including new secondary badge to differentiate option like drafting in badges

Fixes #1909

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

Manual review steps

  1. Created new project in test app using drafting option from stages

drafting_badge

@sarvaiyanidhi sarvaiyanidhi marked this pull request as draft August 16, 2023 16:47
@codeclimate
Copy link

codeclimate bot commented Aug 16, 2023 •
edited

Code Climate has analyzed commit 54197b3 and detected 0 issues on this pull request.

View more on Code Climate.

adrianthedev
adrianthedev approved these changes Aug 16, 2023
View reviewed changes
Copy link
Collaborator

@adrianthedev adrianthedev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work @sarvaiyanidhi!

Thank you for this contribution!

@sarvaiyanidhi
Copy link
Contributor Author

Amazing work @sarvaiyanidhi!

Thank you for this contribution!

Thank you! There is failing spec so checking it out though it is not due to current code changes.

@sarvaiyanidhi sarvaiyanidhi marked this pull request as ready for review August 16, 2023 18:15
@adrianthedev adrianthedev merged commit 40f0d29 into avo-hq:main Aug 16, 2023
10 checks passed
@adrianthedev adrianthedev added the Enhancement New feature or request label Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrianthedev adrianthedev adrianthedev approved these changes

Assignees
No one assigned
Labels
Enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New badge state for secondary (grey) useful for "drafting"
2 participants
@sarvaiyanidhi @adrianthedev