Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: search count is incorrect when attach_scope #1932

Merged
merged 1 commit into from
Sep 12, 2023

Conversation

Paul-Bob
Copy link
Contributor

Description

Fixes #1930

This PR applies the scopes before making the count on search.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@Paul-Bob Paul-Bob self-assigned this Aug 31, 2023
@github-actions github-actions bot added the Fix label Aug 31, 2023
@codeclimate
Copy link

codeclimate bot commented Aug 31, 2023

Code Climate has analyzed commit f801133 and detected 0 issues on this pull request.

View more on Code Climate.

@Paul-Bob Paul-Bob merged commit 9847f8c into main Sep 12, 2023
14 checks passed
@Paul-Bob Paul-Bob deleted the fix/search_count_is_incorrect_when_attach_scope branch September 12, 2023 07:50
@github-actions
Copy link
Contributor

This PR has been merged into main. The functionality will be available in the next release.

Please check the release guide for more information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search count is incorrect, when attach_scope
1 participant