-
-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: file image doesn't render in full size #1935
Conversation
Code Climate has analyzed commit 849c5dd and detected 0 issues on this pull request. View more on Code Climate. |
app/components/avo/fields/common/files/view_type/grid_component.html.erb
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What if someone wants to apply that aspect ratio?
How about this?
we add all Tailwind aspect-
classes in the whitelist file and folks can apply it when they want it with the html
option.
Is that something we could support?
How would you target that specific div with |
About the white list file, there are too many combination, we can't guess all what users want to use (sure we can add the PS: @adrianthedev maybe this issue (Allow variants on file fields) is related, I see people wanting to use variants, that it's even more customizable than |
@adrianthedev the |
This PR has been marked as stale because there was no activity for the past 15 days. |
This PR has been merged into Please check the release guide for more information. |
Description
Fixes #1897
File image was applying
aspect-video
forcing the image to render on 16/9 aspect ratio format. This PR removes that format.Checklist: