Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: variant resize image #1964

Merged
merged 4 commits into from
Oct 9, 2023
Merged

fix: variant resize image #1964

merged 4 commits into from
Oct 9, 2023

Conversation

Paul-Bob
Copy link
Contributor

@Paul-Bob Paul-Bob commented Oct 9, 2023 •
edited

Description

image

Fixes #1948

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

Manual review steps

  1. Step 1
  2. Step 2

Manual reviewer: please leave a comment with output from the test if that's the case.

@Paul-Bob Paul-Bob added the Fix label Oct 9, 2023
@Paul-Bob Paul-Bob self-assigned this Oct 9, 2023
@codeclimate
Copy link

codeclimate bot commented Oct 9, 2023 •
edited

Code Climate has analyzed commit 6e7337d and detected 0 issues on this pull request.

View more on Code Climate.

@Paul-Bob Paul-Bob merged commit 7118e51 into main Oct 9, 2023
13 checks passed
@Paul-Bob Paul-Bob deleted the fix/variant_resize_image branch October 9, 2023 13:00
@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2023

This PR has been merged into main. The functionality will be available in the next release.

Please check the release guide for more information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrianthedev adrianthedev Awaiting requested review from adrianthedev

Assignees

@Paul-Bob Paul-Bob

Labels
Fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow variants on file field
2 participants
@Paul-Bob @adrianthedev