Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: allow custom cache store & improve the computed one #1983

Merged
merged 4 commits into from
Oct 18, 2023
Merged

feature: allow custom cache store & improve the computed one #1983

merged 4 commits into from
Oct 18, 2023

Conversation

Paul-Bob
Copy link
Contributor

Description

Fixes #1982

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

Manual review steps

  1. Step 1
  2. Step 2

Manual reviewer: please leave a comment with output from the test if that's the case.

@Paul-Bob Paul-Bob self-assigned this Oct 18, 2023
@codeclimate
Copy link

codeclimate bot commented Oct 18, 2023 •
edited

Code Climate has analyzed commit a9741df and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 1

View more on Code Climate.

adrianthedev
adrianthedev approved these changes Oct 18, 2023
View reviewed changes
Copy link
Collaborator

@adrianthedev adrianthedev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add to th einitializer a commented out example on how they can switch to Solid cache.

@Paul-Bob Paul-Bob changed the title improvement: cache feature: allow custom cache store & improve the coputed one Oct 18, 2023
@Paul-Bob Paul-Bob changed the title feature: allow custom cache store & improve the coputed one feature: allow custom cache store & improve the computed one Oct 18, 2023
@Paul-Bob Paul-Bob merged commit 4fd895f into main Oct 18, 2023
11 of 13 checks passed
@Paul-Bob Paul-Bob deleted the improvement/cache branch October 18, 2023 09:32
@github-actions
Copy link
Contributor

This PR has been merged into main. The functionality will be available in the next release.

Please check the release guide for more information.

@Paul-Bob Paul-Bob mentioned this pull request Oct 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeclimate codeclimate[bot] codeclimate left review comments

@adrianthedev adrianthedev Awaiting requested review from adrianthedev

Assignees

@Paul-Bob Paul-Bob

Labels
Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for custom cache store
2 participants
@Paul-Bob @adrianthedev