fix: message don't appear on fail destroy on associations #2016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code Climate has analyzed commit c9afba0 and detected 0 issues on this pull request. View more on Code Climate. |
adrianthedev
approved these changes
Nov 13, 2023
| respond_to do |format| | ||
| format.html { redirect_back fallback_location: params[:referrer] || resources_path(resource: @resource, turbo_frame: params[:turbo_frame], view_type: params[:view_type]), error: destroy_fail_message } | ||
| format.turbo_stream { render partial: "avo/partials/flash_alerts" } |
There was a problem hiding this comment.
Are you sure that removing the redirect does not break other flows?
There was a problem hiding this comment.
None that I tested or that is covered by automatic tests
| @@ -1,3 +1,3 @@ | |||
| <%= turbo_stream.append "alerts" do %> | |||
| <%= render Avo::FlashAlertsComponent.new flashes: flash %> | |||
| <%= render Avo::FlashAlertsComponent.new flashes: flash.discard %> | |||
There was a problem hiding this comment.
Are we sure that the discard works well with other flows as well?
There was a problem hiding this comment.
I think so, it will discard the entire flash at the end of the current action
Paul-Bob
deleted the
fix/message_do_not_appear_on_fail_destroy_on_associations
branch
|
This PR has been merged into Please check the release guide for more information. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1918
Turbo stream errors on destroy should be more efficient and error proof
Before
before.webm
After
after.webm
Checklist:
Manual review steps
Manual reviewer: please leave a comment with output from the test if that's the case.