fix: detach should not destroy attachment

[Paul-Bob]

Description

This change intended to make sure that validations / callbacks are called when detaching a record from a has_many associations. Unfortunately it introduced a bug where the record getting detached is actually deleted from DB.

destroy(*records)

...
This method will always remove record from the database ignoring the :dependent option.
...

Delete is what we want here but delete(*records) will not run associations callbacks...

Fixes https://discord.com/channels/740892036978442260/1157144752752427048

We should find a way to trigger associations callbacks using delete or another strategy.

Checklist:

• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• I have added tests that prove my fix is effective or that my feature works

[codeclimate]

Code Climate has analyzed commit 0401834 and detected 0 issues on this pull request.

View more on Code Climate.

[github-actions]

This PR has been merged into main. The functionality will be available in the next release.

Please check the release guide for more information.

[Paul-Bob]

delete triggered before_remove and after_remove on my tests...

[yshmarov]

thanks!

[adrianthedev]

This should be out in nothe Avo 2 & 3