Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: extract fields from sidebar and add them to permitted params #2053

Merged
merged 8 commits into from
Nov 23, 2023
Merged

fix: extract fields from sidebar and add them to permitted params #2053

merged 8 commits into from
Nov 23, 2023

Conversation

Paul-Bob
Copy link
Contributor

@Paul-Bob Paul-Bob commented Nov 23, 2023 •
edited

Description

Extract fields from sidebars and add them to permitted params.

Fixes #2051

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@Paul-Bob Paul-Bob added the Fix label Nov 23, 2023
@Paul-Bob Paul-Bob self-assigned this Nov 23, 2023
@codeclimate CodeClimate
Copy link

codeclimate bot commented Nov 23, 2023 •
edited

Code Climate has analyzed commit f0c9ba1 and detected 0 issues on this pull request.

View more on Code Climate.

@Paul-Bob Paul-Bob merged commit 83c7aa5 into main Nov 23, 2023
11 checks passed
@Paul-Bob Paul-Bob deleted the fix/allow_sidebar_fields_on_forms branch November 23, 2023 14:21
@github-actions GitHub Actions
Copy link
Contributor

This PR has been merged into main. The functionality will be available in the next release.

Please check the release guide for more information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeclimate codeclimate[bot] codeclimate left review comments

@adrianthedev adrianthedev Awaiting requested review from adrianthedev

Assignees

@Paul-Bob Paul-Bob

Labels
Fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fields in sidebar won't get permitted on form submission
1 participant
@Paul-Bob