Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: disable belongs_to creation from association #2057

Merged
merged 4 commits into from
Dec 4, 2023
Merged

feature: disable belongs_to creation from association #2057

merged 4 commits into from
Dec 4, 2023

Conversation

Paul-Bob
Copy link
Contributor

@Paul-Bob Paul-Bob commented Nov 23, 2023 •
edited

Description

can_create: false now disables the link to create from the belongs_to field

Fixes #2033

Checklist:

Screenshots

WARNING: allow_creation option was renamed to can_create

image

image

@Paul-Bob Paul-Bob self-assigned this Nov 23, 2023
@codeclimate CodeClimate
Copy link

codeclimate bot commented Nov 23, 2023 •
edited

Code Climate has analyzed commit 36cff0c and detected 0 issues on this pull request.

View more on Code Climate.

adrianthedev
adrianthedev approved these changes Dec 4, 2023
View reviewed changes
Copy link
Collaborator

@adrianthedev adrianthedev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's rename the option to can_create

@Paul-Bob Paul-Bob merged commit c17d9ca into main Dec 4, 2023
11 checks passed
@Paul-Bob Paul-Bob deleted the feature/disable_belongs_to_creation_from_association branch December 4, 2023 14:30
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 4, 2023

This PR has been merged into main. The functionality will be available in the next release.

Please check the release guide for more information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrianthedev adrianthedev adrianthedev approved these changes

Assignees

@Paul-Bob Paul-Bob

Labels
Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hide the ability to add a belongs to from the parent record
2 participants
@Paul-Bob @adrianthedev