fix: actions download

[Paul-Bob]

Description

Fixes #2184

• may_download_file become deprecated and is no longer being used, can safely be removed from all actions.
• Fixes early error messages return on download actions
• Fixes keep modal open feature on download actions
• Refactors the way that actions download works
  • Use turbo stream to a custom stream action that triggers the download using FileSaver.js lib

Checklist:

• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
  • actions upgrade guide docs.avohq.io#154
• I have added tests that prove my fix is effective or that my feature works

Screenshots

Manual review steps

1. Step 1
2. Step 2

Manual reviewer: please leave a comment with output from the test if that's the case.

[codeclimate]

Code Climate has analyzed commit f612e82 and detected 0 issues on this pull request.

View more on Code Climate.

[adrianthedev]

If we have tests supporting this use case, then it's good to merge.

Thank you!

[Paul-Bob]

If we have tests supporting this use case, then it's good to merge.

Thank you!

We have several tests around actions, download, keeping modal open, alerts, etc... Are all being already tested.

[github-actions]

This PR has been merged into main. The functionality will be available in the next release.

Please check the release guide for more information.