Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: HABTM cant find associations with custom class_name #237

Merged
merged 1 commit into from Feb 16, 2021

Conversation

adrianthedev
Copy link
Collaborator

Fixes #236

@github-actions github-actions bot added the Fix label Feb 16, 2021
@codecov
Copy link

codecov bot commented Feb 16, 2021

Codecov Report

Merging #237 (9fee760) into master (8a13028) will increase coverage by 0.72%.
The diff coverage is 93.60%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #237      +/-   ##
==========================================
+ Coverage   96.03%   96.76%   +0.72%     
==========================================
  Files          87      136      +49     
  Lines        1890     3859    +1969     
==========================================
+ Hits         1815     3734    +1919     
- Misses         75      125      +50     
Impacted Files Coverage Δ
lib/avo/app/tools_manager.rb 50.00% <50.00%> (ø)
lib/avo/app/fields/belongs_to.rb 90.00% <75.00%> (ø)
lib/avo/app/action.rb 80.48% <80.48%> (ø)
lib/avo/engine.rb 85.71% <85.71%> (ø)
lib/avo/app/fields/boolean_field.rb 93.75% <87.50%> (ø)
lib/avo/app/app.rb 89.61% <89.61%> (ø)
lib/avo/app/resource.rb 90.35% <90.35%> (ø)
lib/avo/app/fields/key_value_field.rb 90.90% <90.90%> (ø)
app/controllers/avo/resources_controller.rb 91.45% <91.45%> (ø)
.../avo/app/fields/field_extensions/has_field_name.rb 91.66% <91.66%> (ø)
... and 176 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 779951c...9fee760. Read the comment docs.

@adrianthedev adrianthedev merged commit 12b106d into master Feb 16, 2021
@adrianthedev adrianthedev deleted the fix/habtm-cant-find-custom-class-relations branch February 16, 2021 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

has_and_belongs_to_many does not find the model if option class_name is specified
1 participant