feature: mark highlight search #2370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code Climate has analyzed commit 466ec03 and detected 0 issues on this pull request. View more on Code Climate. |
adrianthedev
requested changes
Jan 16, 2024
adrianthedev
requested changes
Jan 16, 2024
Paul-Bob
reviewed
Jan 16, 2024
adrianthedev
approved these changes
Jan 17, 2024
Comment on lines
13
to
14
| rescue StandardError => e | ||
| render_search_error(e) |
There was a problem hiding this comment.
Let's remove this please.
| @@ -60,7 +61,7 @@ def search_resource(resource) | |||
|
|
|||
| result_object = { | |||
| header: header, | |||
| help: resource.fetch_search(:help) || "", | |||
| help: resource.fetch_search(:help) || '', | |||
Paul-Bob
approved these changes
Jan 17, 2024
|
Congrats @gabrielgiroe1 for your first merged PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2014
Checklist:
Screenshots
Manual review steps
Manual reviewer: please leave a comment with output from the test if that's the case.