fix: destroy when using forms and display fields API

Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    avo (3.3.1)
+    avo (3.3.2)
       actionview (>= 6.1)
       active_link_to
       activerecord (>= 6.1)

app/components/avo/index/resource_controls_component.rb

@@ -182,6 +182,7 @@ def hidden_params
     hidden = {}
 
     hidden[:view_type] = params[:view_type] if params[:view_type]
+    hidden[:view] = resource.view.to_s
 
     if params[:turbo_frame]
       hidden[:turbo_frame] = params[:turbo_frame]

app/controllers/avo/application_controller.rb

@@ -119,7 +119,26 @@ def detect_fields
     def set_related_resource
       raise Avo::MissingResourceError.new(related_resource_name) if related_resource.nil?
 
-      @related_resource = related_resource.new(params: params, view: action_name.to_sym, user: _current_user, record: @related_record).detect_fields
+      action_view = action_name.to_sym
+
+      # Get view from params unless actions is index or show or forms...
+      # Else, for example for detach action we want the view from params to can fetch the correct fields
+      # This logic avoid the following scenario:
+      # When a has many field is rendered the action is index and params[:view] is show or edit but we want to
+      # keep @view as index for the related_resource
+      # Same do not happen with other actions except the list below.
+      view = if action_view.in?([:index, :show, :new, :edit, :create])
+        action_view
+      else
+        params[:view] || action_view
+      end
+
+      @related_resource = related_resource.new(
+        params: params,
+        view: view,
+        user: _current_user,
+        record: @related_record
+      ).detect_fields
     end
 
     def set_record

spec/dummy/app/avo/resources/course.rb

@@ -5,7 +5,16 @@ class Avo::Resources::Course < Avo::BaseResource
   self.keep_filters_panel_open = true
   self.stimulus_controllers = "city-in-country toggle-fields"
 
-  def fields
+
+  def display_fields
+    fields_bag
+  end
+
+  def form_fields
+    fields_bag
+  end
+
+  def fields_bag
     field :id, as: :id
     field :name, as: :text, html: {
       edit: {

spec/features/avo/fields_methods_for_views_spec.rb

@@ -69,6 +69,9 @@ def index_fields
     end
 
     it "shows only the specified fields for display views" do
+      # Store the original method
+      original_display_fields = Avo::Resources::Course.instance_method(:display_fields)
+
       Avo::Resources::Course.class_eval do
         def display_fields
           field :id, as: :id
@@ -102,12 +105,16 @@ def display_fields
       expect(page).not_to have_selector 'turbo-frame[id="has_many_field_show_links"]'
 
 
+      # Restore the original method
       Avo::Resources::Course.class_eval do
-        remove_method :display_fields
+        define_method(:display_fields, original_display_fields)
       end
     end
 
     it "shows only the specified fields for form views" do
+      # Store the original method
+      original_form_fields = Avo::Resources::Course.instance_method(:form_fields)
+
       Avo::Resources::Course.class_eval do
         def form_fields
           field :name, as: :text
@@ -138,9 +145,9 @@ def form_fields
       expect(page).not_to have_css "[data-field-id='city']"
       expect(page).not_to have_selector 'turbo-frame[id="has_many_field_show_links"]'
 
-
+      # Restore the original method
       Avo::Resources::Course.class_eval do
-        remove_method :form_fields
+        define_method(:form_fields, original_form_fields)
       end
     end
   end