Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: attach when using *_fields API #2459

Merged
merged 1 commit into from Feb 7, 2024

Conversation

Paul-Bob
Copy link
Contributor

@Paul-Bob Paul-Bob commented Feb 7, 2024

Description

Fixes #2403

Related to #2403 (fixed detach) but this PR fixes attach action

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

Screenshots & recording

Manual review steps

  1. Step 1
  2. Step 2

Manual reviewer: please leave a comment with output from the test if that's the case.

@Paul-Bob Paul-Bob added the Fix label Feb 7, 2024
@Paul-Bob Paul-Bob self-assigned this Feb 7, 2024
Copy link

codeclimate bot commented Feb 7, 2024

Code Climate has analyzed commit d457b3b and detected 0 issues on this pull request.

View more on Code Climate.

@Paul-Bob Paul-Bob merged commit 09ff10a into main Feb 7, 2024
23 checks passed
@Paul-Bob Paul-Bob deleted the fix/attach_when_using_view_fields_api branch February 7, 2024 11:47
Copy link
Contributor

github-actions bot commented Feb 7, 2024

This PR has been merged into main. The functionality will be available in the next release.

Please check the release guide for more information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

def display_fields / form_fields do not cover detach
1 participant