Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes a regression (broken index destroy action) introduced here #2436
params[:view]
was passed as empty string""
and we were doingparams[:view] || action_name.to_s
which would result in empty string""
since:A resource with the
view
value asnil
breaks fetching fields. This is fixed now and resource'sview
have the propper valueChecklist:
I have commented my code, particularly in hard-to-understand areasI have made corresponding changes to the documentationManual review steps