Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: action link_arguments compact params #2530

Merged
merged 1 commit into from Feb 28, 2024

Conversation

Paul-Bob
Copy link
Contributor

@Paul-Bob Paul-Bob commented Feb 28, 2024

Description

When using link_arguments all params should be compact and don't pass empty params like: ?arguments=&etc...

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@Paul-Bob Paul-Bob self-assigned this Feb 28, 2024
Copy link

codeclimate bot commented Feb 28, 2024

Code Climate has analyzed commit fed2eb2 and detected 0 issues on this pull request.

View more on Code Climate.

@github-actions github-actions bot added the Fix label Feb 28, 2024
@Paul-Bob Paul-Bob merged commit feedbf3 into main Feb 28, 2024
20 of 21 checks passed
@Paul-Bob Paul-Bob deleted the fix/action_link_arguments_compact_params branch February 28, 2024 14:13
Copy link
Contributor

This PR has been merged into main. The functionality will be available in the next release.

Please check the release guide for more information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant