Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: enable coverage in Undercover CI #2536

Merged
merged 4 commits into from Mar 31, 2024
Merged

Conversation

adrianthedev
Copy link
Collaborator

Description

Fixes # (issue)

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

Copy link

codeclimate bot commented Feb 29, 2024

Code Climate has analyzed commit 36cea00 and detected 0 issues on this pull request.

View more on Code Climate.

.github/workflows/undercover.yml Fixed Show resolved Hide resolved
@adrianthedev adrianthedev marked this pull request as ready for review February 29, 2024 07:56
Copy link
Contributor

This PR has been marked as stale because there was no activity for the past 15 days.

@github-actions github-actions bot added the Stale label Mar 24, 2024
ruby scripts/merge_coverage.rb coverage_all.lcov
- run: |
ruby -e "$(curl -s https://undercover-ci.com/uploader.rb)" -- \
--repo grodowski/avo \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to change to avo-hq/avo and install Undercover GH app before merging

def hallo
puts "Nobody tested me yet :("
puts "Nobody tested me yet :("
puts "Nobody tested me yet :("
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: Remove :)

@grodowski
Copy link
Contributor

@adrianthedev could you approve the workflows so that we can check if all configs works on the base repo?

@adrianthedev
Copy link
Collaborator Author

Done @grodowski!

@adrianthedev
Copy link
Collaborator Author

This looks good @grodowski. Should I merge it and see the results?

@grodowski
Copy link
Contributor

Sounds good! I am surprised Github didn't run the undercover.yml merge coverage workflow. Can we assume it will happen once the code is no longer a fork?

@adrianthedev adrianthedev merged commit 2887838 into avo-hq:main Mar 31, 2024
18 of 19 checks passed
@Paul-Bob Paul-Bob changed the title Enable coverage in Undercover CI chore: enable coverage in Undercover CI Apr 3, 2024
@Paul-Bob Paul-Bob added the Chore label Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants