Use human model name when creating new polymorphic association

[iainbeeston]

Description

Use the human model name in the link for creating a new polymorphic association, instead of the class name

Fixes # (issue)

Right now, when you have a polymorphic belongs to field and you specify the types argument (so the field shows a useful select menu allowing you to choose from the different polymorphic types) it has a link below the select menu saying "Create new ". However, the name it uses for the resource is the class name used in the code, which isn't very user-friendly.

Checklist:

• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• I have added tests that prove my fix is effective or that my feature works

Screenshots & recording

This is what it looks like before (note the class name with modules in the link):

This is what it looks like after:

Manual review steps

1. Find a polymorphic belongs to field that uses types, eg. https://main.avodemo.com/avo/resources/comments/549/edit
2. Switch to this branch
3. Confirm that the "create new " hasn't changed
4. Change the human name for the polymorphic class in the rails translations file
5. Reload avo and confirm that the name has updated to use the new translation

Manual reviewer: please leave a comment with output from the test if that's the case.

[codeclimate]

Code Climate has analyzed commit 8fa6a81 and detected 0 issues on this pull request.

View more on Code Climate.

[Paul-Bob]

Thanks for this fix @iainbeeston !