Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: search item title #2609

Merged
merged 1 commit into from Mar 20, 2024
Merged

fix: search item title #2609

merged 1 commit into from Mar 20, 2024

Conversation

Paul-Bob
Copy link
Contributor

Description

Fixes #2535

Use to_s on the search title before trying to highlight it.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@Paul-Bob Paul-Bob added the Fix label Mar 18, 2024
@Paul-Bob Paul-Bob self-assigned this Mar 18, 2024
Copy link

codeclimate bot commented Mar 18, 2024

Code Climate has analyzed commit 9436a98 and detected 0 issues on this pull request.

View more on Code Climate.

Copy link
Collaborator

@adrianthedev adrianthedev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks!

@Paul-Bob Paul-Bob merged commit 432ef75 into main Mar 20, 2024
20 checks passed
@Paul-Bob Paul-Bob deleted the fix/search_item_title branch March 20, 2024 05:15
Copy link
Contributor

This PR has been merged into main. The functionality will be available in the next release.

Please check the release guide for more information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search result highlight got error
2 participants