fix: collect errors from record without exception

[Paul-Bob]

Description

Fixes #2602

Collect errors from record even if nothing is raised. Errors can be added on callbacks without raising exception. Action fail if any error is present

Checklist:

• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• I have added tests that prove my fix is effective or that my feature works

[codeclimate]

Code Climate has analyzed commit 290d118 and detected 0 issues on this pull request.

View more on Code Climate.

[adrianthedev]

I wonder what side effects this might have for existing users.
Maybe some existing users have some errors in their models that fail silently. This PR will trigger errors for them, is that correct?

[Paul-Bob]

Maybe some existing users have some errors in their models that fail silently. This PR will trigger errors for them, is that correct?

If there are errors on the record but no exception is raised it does not fail right now, the record is saved and errors are swallowed.

If someone is in this scenario yes, same workflow will now break with this approach and show the errors, IMO that's good, if errors are present the create / update action should fail.

[adrianthedev]

Got it!
Sounds good!
Let's ship it and make a note in the upgrade guide.

[github-actions]

This PR has been merged into main. The functionality will be available in the next release.

Please check the release guide for more information.