Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: date_time fields timezone #2623

Merged
merged 6 commits into from Mar 25, 2024
Merged

fix: date_time fields timezone #2623

merged 6 commits into from Mar 25, 2024

Conversation

Paul-Bob
Copy link
Contributor

@Paul-Bob Paul-Bob commented Mar 21, 2024

Description

Fixes #2510

Flatpickr is always using the local timezone when editing. If timezone option is present it will ignore it. With this PR we change the timezone of the selected input keeping the date and time values before converting it to UTC.

Force timezone option when UTC to Etc/UTC on edit due this issue moment/luxon#1358

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@Paul-Bob Paul-Bob added the Fix label Mar 21, 2024
@Paul-Bob Paul-Bob self-assigned this Mar 21, 2024
@Paul-Bob Paul-Bob marked this pull request as draft March 21, 2024 11:06
Copy link

codeclimate bot commented Mar 21, 2024

Code Climate has analyzed commit e2488e7 and detected 0 issues on this pull request.

View more on Code Climate.

Paul-Bob and others added 3 commits March 21, 2024 14:10
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@Paul-Bob Paul-Bob marked this pull request as ready for review March 25, 2024 09:16
@Paul-Bob Paul-Bob merged commit 5733e8e into main Mar 25, 2024
19 checks passed
@Paul-Bob Paul-Bob deleted the fix/date_time_field branch March 25, 2024 09:36
Copy link
Contributor

This PR has been merged into main. The functionality will be available in the next release.

Please check the release guide for more information.

@Paul-Bob Paul-Bob mentioned this pull request Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Timezone discrepancy on datetime fields
1 participant