Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: keep avo.custom.js template on build #2641

Merged
merged 1 commit into from Mar 27, 2024

Conversation

Paul-Bob
Copy link
Contributor

Description

Fixes #2411

Keep avo.custom.js template on build, remove only the dummy app avo.custom.js file.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@Paul-Bob Paul-Bob added the Fix label Mar 27, 2024
@Paul-Bob Paul-Bob self-assigned this Mar 27, 2024
Copy link

codeclimate bot commented Mar 27, 2024

Code Climate has analyzed commit 8c61405 and detected 0 issues on this pull request.

View more on Code Climate.

@Paul-Bob Paul-Bob merged commit 948f83d into main Mar 27, 2024
20 checks passed
@Paul-Bob Paul-Bob deleted the fix/keep_avo.custom.js_template branch March 27, 2024 13:09
Copy link
Contributor

This PR has been merged into main. The functionality will be available in the next release.

Please check the release guide for more information.

@adrianthedev
Copy link
Collaborator

Why did we do this? It seems we already have an empty avo.custom.js at lib/generators/avo/templates/js/avo.custom.js.

@adrianthedev
Copy link
Collaborator

Oh. misread it when I read the title... we are actually rejecting the dummy one and keeping the good empty one.
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

avo:js:install fails
2 participants