fix: resource search

[gabrielgiroe1]

Description

Implement resource search functionality in cases where there are no existing policies defined for the resource.

Fixes https://discord.com/channels/740892036978442260/1223913103998193664

Checklist:

• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• I have added tests that prove my fix is effective or that my feature works

[codeclimate]

Code Climate has analyzed commit 494aa59 and detected 0 issues on this pull request.

View more on Code Climate.

[Paul-Bob]

has_action_method?(argument) will pick the argument and use it as key to access the Avo.configuration.authorization_methods hash that looks like:

      @authorization_methods = {
        index: "index?",
        show: "show?",
        edit: "edit?",
        new: "new?",
        update: "update?",
        create: "create?",
        destroy: "destroy?"
      }

avo_search? is something specific that the user can set like:

Avo.configure do |config|
  # ...

  ## == Authorization ==
  config.authorization_methods = {
    # ...
    search: "avo_search?" # override this method
  }

  # ...
end

It can be even can_search_or_not? if the user configure it with:

Avo.configure do |config|
  # ...

  ## == Authorization ==
  config.authorization_methods = {
    # ...
    search: "can_search_or_not?" # override this method
  }

  # ...
end

We should always access the search key to verify if the method exists.

[Paul-Bob]

Hello @gabrielgiroe1 I let a comment about readability, otherwise the logic seems correct.

[Paul-Bob]

@gabrielgiroe1 just noticed that we can simplify the method.

Lets try this approach, I think this will have the desired output:

  def authorized_to_search?
    resource.authorization.authorize_action("search", raise_exception: false)
  end

Can you please check this scenarios?

1. On avo, without avo-pro installed resource search should be working.
2. On avo-pro with config.authorization_client = nil should be working.
3. On avo-pro with pundit as client but without policy configured for the resource should be working.
4. On avo-pro with pundit as client and without the search method defined should search should not work.
5. On avo-pro with pundit as client and with the search method defined returning false should search should not work.
6. On avo-pro with pundit as client and with the search method defined returning true search should work.

[gabrielgiroe1]

Yes, you are right. I tested it with these changes and it work as expected.

[Paul-Bob]

Thanks @gabrielgiroe1 it's looking great!

[github-actions]

This PR has been merged into main. The functionality will be available in the next release.

Please check the release guide for more information.