Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: select boolean false value #2662

Merged
merged 1 commit into from Apr 5, 2024
Merged

Conversation

Paul-Bob
Copy link
Contributor

@Paul-Bob Paul-Bob commented Apr 5, 2024

Description

Fixes select field on boolean attributes when value is false.

field :is_capital,
  as: :select,
  options: {
    'Yes': true,
    'No': false
  }

1 - Before
2 - After

image

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@Paul-Bob Paul-Bob added the Fix label Apr 5, 2024
@Paul-Bob Paul-Bob self-assigned this Apr 5, 2024
Copy link

codeclimate bot commented Apr 5, 2024

Code Climate has analyzed commit d4cca0f and detected 0 issues on this pull request.

View more on Code Climate.

@Paul-Bob Paul-Bob merged commit 79aa120 into main Apr 5, 2024
20 of 21 checks passed
@Paul-Bob Paul-Bob deleted the fix/select_boolean_false_value branch April 5, 2024 08:01
Copy link
Contributor

github-actions bot commented Apr 5, 2024

This PR has been merged into main. The functionality will be available in the next release.

Please check the release guide for more information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant