Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in undercover.yml GitHub Action workflow #2668

Merged
merged 2 commits into from Apr 8, 2024

Conversation

grodowski
Copy link
Contributor

Description

Fixes command typo and adds an untested patch to check the full feedback loop with Undercover.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

Screenshots & recording

Manual review steps

  1. Step 1
  2. Step 2

Manual reviewer: please leave a comment with output from the test if that's the case.

Copy link

codeclimate bot commented Apr 8, 2024

Code Climate has analyzed commit a26206f and detected 0 issues on this pull request.

View more on Code Climate.

@grodowski
Copy link
Contributor Author

@adrianthedev tiny fix to unblock Undercover. The untested method should receive a check warning if everything works as expected.

@adrianthedev adrianthedev merged commit 530c942 into avo-hq:main Apr 8, 2024
19 checks passed
@adrianthedev
Copy link
Collaborator

Thanks @grodowski

@adrianthedev
Copy link
Collaborator

I still see some errors @grodowski.
No hurry, but wanted to surface them out.

@Paul-Bob Paul-Bob added the Fix label Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants