New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: audit logs #2703
base: main
Are you sure you want to change the base?
feature: audit logs #2703
Conversation
Code Climate has analyzed commit cdde642 and detected 1 issue on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
payload: payload.to_json | ||
) | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[rubocop] reported by reviewdog 🐶
[Corrected] Layout/EmptyLines: Extra blank line detected.
true | ||
end | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[rubocop] reported by reviewdog 🐶
[Corrected] Layout/EmptyLines: Extra blank line detected.
end | ||
|
||
|
||
def audit? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[rubocop] reported by reviewdog 🐶
[Corrected] Layout/EmptyLineBetweenDefs: Expected 1 empty line between method definitions; found 2.
@@ -160,7 +162,9 @@ def license=(value) | |||
def license | |||
gems = Gem::Specification.map {|gem| gem.name} | |||
|
|||
@license ||= if gems.include?("avo-advanced") | |||
@license ||= if gems.include?("avo-audits") | |||
"enterprise" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why? 😢
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you consider moving the audit feature to the advanced plan?
Description
Fixes # (issue)
Checklist:
Screenshots & recording
Manual review steps
Manual reviewer: please leave a comment with output from the test if that's the case.