fix: table cache

[Paul-Bob]

Description

Fixes #2732

Refactor rows and header cache

Checklist:

• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• I have added tests that prove my fix is effective or that my feature works

[codeclimate]

Code Climate has analyzed commit 4e875ad and detected 0 issues on this pull request.

View more on Code Climate.

[github-actions]

This PR has been merged into main. The functionality will be available in the next release.

Please check the release guide for more information.

[adrianthedev]

Could please leave a message to why this refactor was done?

[Paul-Bob]

Could please leave a message to why this refactor was done?

Sure, full context on the fixed issue: #2732

Instance variables was defined and assigned inside cache_if block which would not run if result already cached.

We actually want the cache_if block to cache a result and assign to instance variables every time that table component renders.

Pseudo code that explains the refactor:

Before:

cache_if ...
  @variable = value
end

After:

@variable = cache_if ...
  value
end

Makes sense?

[adrianthedev]

Got it! Thank you!