Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wrong label on belongs_tofield #2758

Merged
merged 1 commit into from
May 9, 2024

Conversation

adrianthedev
Copy link
Collaborator

Description

Fixes #1929

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@github-actions github-actions bot added the Fix label May 9, 2024
Copy link

codeclimate bot commented May 9, 2024

Code Climate has analyzed commit 5dd8194 and detected 0 issues on this pull request.

View more on Code Climate.

@adrianthedev adrianthedev merged commit 5e0dae2 into main May 9, 2024
20 of 21 checks passed
@adrianthedev adrianthedev deleted the fix/wrong-label-on-belongs-to branch May 9, 2024 12:58
Copy link
Contributor

github-actions bot commented May 9, 2024

This PR has been merged into main. The functionality will be available in the next release.

Please check the release guide for more information.

@xeron
Copy link

xeron commented May 10, 2024

@adrianthedev this doesn't fix the issue. ID is still different:

…
<label for="result_driver">Driver</label>
…
<select … id="result_driver_id"><option value="">Choose an option</option></select>
…

and you can still see in Chrome issues:

Screenshot 2024-05-09 at 5 53 42 PM

@@ -265,6 +265,10 @@ def can_create?
@can_create
end

def form_field_label
id
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should have been "#{id}_id" probably?

@adrianthedev adrianthedev mentioned this pull request May 10, 2024
4 tasks
@adrianthedev
Copy link
Collaborator Author

You're right @xeron.
I refactored the code but didn't apply the fix.

I took this oportunity to also improve & slim down the JS controller.

@adrianthedev
Copy link
Collaborator Author

It'll be fixed in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect label for belongs_to selects
2 participants