fix: truncate long action messages to avoid overflow

[gabrielgiroe1]

Description

Implement message truncation to 320 characters on action.

Fixes #2707

Checklist:

• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• I have added tests that prove my fix is effective or that my feature works

Screenshots & recording

Manual review steps

1. Step 1
2. Step 2

Manual reviewer: please leave a comment with output from the test if that's the case.

[codeclimate]

Code Climate has analyzed commit 178068d and detected 0 issues on this pull request.

View more on Code Climate.

[Paul-Bob]

I'm approving the PR since it's respecting the request, let's just directly truncate and avoid unnecessary body re-attribution as a performance tweak.

More complex review

This solution may work sometimes but do not fix the CookieOverflow problem. We're storing the messages on flash hash and the default cookie_store has a limit of 4kb. When that limit is exceeded CookieOverflow is raised.

  def handle(**args)
    succeed "🥑"*1600
    warn "🥑"*1600
    inform "🥑"*1600
    error "🥑"*1600
    return
  end

With this truncate solution the above code snippet still breaking because the sum of the 4 truncated messages exceed the 4kb limit.

Sources:

• https://stackoverflow.com/questions/9473808/cookie-overflow-in-rails-application
• https://naoj-gior.medium.com/flash-messages-and-cookie-overflow-c1886c9c3054

[github-actions]

This PR has been merged into main. The functionality will be available in the next release.

Please check the release guide for more information.