Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Status field #60

Merged
merged 21 commits into from Jul 6, 2020
Merged

feature: Status field #60

merged 21 commits into from Jul 6, 2020

Conversation

mihaimdm22
Copy link
Contributor

Still need bit work in test class, but we can discuss in the evening.
Let me know if you have any suggestions.
Thanks!

spec/dummy/db/schema.rb Outdated Show resolved Hide resolved
spec/dummy/db/schema.rb Outdated Show resolved Hide resolved
spec/dummy/db/schema.rb Outdated Show resolved Hide resolved
spec/dummy/db/schema.rb Outdated Show resolved Hide resolved
spec/dummy/db/schema.rb Outdated Show resolved Hide resolved
spec/dummy/db/schema.rb Outdated Show resolved Hide resolved
spec/system/avocado/avocado_status_fields_spec.rb Outdated Show resolved Hide resolved
lib/avocado/app/resource.rb Outdated Show resolved Hide resolved
app/frontend/js/components/Show/StatusField.vue Outdated Show resolved Hide resolved
spec/dummy/db/schema.rb Outdated Show resolved Hide resolved
app/frontend/js/components/Show/StatusField.vue Outdated Show resolved Hide resolved
app/frontend/js/components/Show/StatusField.vue Outdated Show resolved Hide resolved
app/frontend/js/components/Index/StatusField.vue Outdated Show resolved Hide resolved
spec/dummy/app/services/avocado/resources/project.rb Outdated Show resolved Hide resolved
app/frontend/js/components/Index/StatusField.vue Outdated Show resolved Hide resolved
@adrianthedev adrianthedev changed the title feature: status_field done feature: status_field Jul 2, 2020
@adrianthedev adrianthedev changed the title feature: status_field feature: Status field Jul 2, 2020
Copy link
Collaborator

@adrianthedev adrianthedev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make these adjustments, wait for tests then merge

app/frontend/js/components/Index/StatusField.vue Outdated Show resolved Hide resolved
app/frontend/js/components/Index/StatusField.vue Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jul 6, 2020

Codecov Report

Merging #60 into master will increase coverage by 0.17%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #60      +/-   ##
==========================================
+ Coverage   95.79%   95.96%   +0.17%     
==========================================
  Files          83       85       +2     
  Lines        1784     1861      +77     
==========================================
+ Hits         1709     1786      +77     
  Misses         75       75              
Impacted Files Coverage Δ
lib/avocado/app/fields/status_field.rb 100.00% <100.00%> (ø)
lib/avocado/app/resource_fields.rb 100.00% <100.00%> (ø)
...ec/dummy/app/services/avocado/resources/project.rb 100.00% <100.00%> (ø)
spec/system/avocado/avocado_status_field_spec.rb 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2bcd956...101931b. Read the comment docs.

@mihaimdm22 mihaimdm22 merged commit 0915109 into master Jul 6, 2020
@mihaimdm22 mihaimdm22 deleted the feature/status-field branch July 6, 2020 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants