Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Badge field #66

Merged
merged 17 commits into from Jul 3, 2020
Merged

feature: Badge field #66

merged 17 commits into from Jul 3, 2020

Conversation

mihaimdm22
Copy link
Contributor

I think this is complete and we can merge. Open for feedback as well! Let's discuss in the long meeting we ll have.

@codecov
Copy link

codecov bot commented Jul 1, 2020

Codecov Report

Merging #66 into master will increase coverage by 0.14%.
The diff coverage is 99.11%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #66      +/-   ##
==========================================
+ Coverage   95.30%   95.45%   +0.14%     
==========================================
  Files          75       77       +2     
  Lines        1533     1605      +72     
==========================================
+ Hits         1461     1532      +71     
- Misses         72       73       +1     
Impacted Files Coverage Δ
lib/avocado/app/fields/badge_field.rb 95.00% <95.00%> (ø)
lib/avocado/app/fields/belongs_to.rb 97.14% <100.00%> (-0.08%) ⬇️
lib/avocado/app/fields/boolean_field.rb 100.00% <100.00%> (ø)
lib/avocado/app/fields/boolean_group_field.rb 100.00% <100.00%> (ø)
lib/avocado/app/fields/date_field.rb 100.00% <100.00%> (ø)
lib/avocado/app/fields/datetime_field.rb 100.00% <100.00%> (ø)
lib/avocado/app/fields/field.rb 98.27% <100.00%> (+0.16%) ⬆️
lib/avocado/app/fields/file_field.rb 80.95% <100.00%> (ø)
lib/avocado/app/fields/files_field.rb 80.00% <100.00%> (ø)
lib/avocado/app/fields/has_and_belongs_to_many.rb 95.83% <100.00%> (-0.17%) ⬇️
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27afeba...d8ce0c6. Read the comment docs.

Copy link
Collaborator

@adrianthedev adrianthedev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few things to do here.

.vscode/launch.json Outdated Show resolved Hide resolved
spec/dummy/db/schema.rb Outdated Show resolved Hide resolved
app/frontend/js/components/Index/BadgeField.vue Outdated Show resolved Hide resolved
app/frontend/js/components/Index/BadgeField.vue Outdated Show resolved Hide resolved
app/frontend/js/components/Show/BadgeField.vue Outdated Show resolved Hide resolved
lib/avocado/app/fields/badge_field.rb Outdated Show resolved Hide resolved
lib/avocado/app/resource_fields.rb Show resolved Hide resolved
spec/system/avocado/avocado_badge_fields_spec.rb Outdated Show resolved Hide resolved
@mihaimdm22 mihaimdm22 changed the title Feature/badge field feature: Badge field Jul 3, 2020
@adrianthedev adrianthedev merged commit 618ba9a into master Jul 3, 2020
@adrianthedev adrianthedev deleted the feature/badge-field branch July 3, 2020 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants