fix: Support older version of Pundit#686
Conversation
Pundit 2.2.0 changes the Module that is required to be included, which is a breaking change. Since Pundit 2.1.x is still very viable for most apps, support both options.
|
Code Climate has analyzed commit 6a536f6 and detected 0 issues on this pull request. View more on Code Climate. |
|
Not sure what you think of this one @adrianthedev. I'm surprised that varvet/pundit@4d9b584 wasn't considered a breaking change (i.e. bumping to Pundit 3.0), but either way, I can't currently fix all of my OTHER dependencies to jump to Pundit v2.2 yet. Does this simple version work or would you rather a Pundit version check? |
Codecov Report
@@ Coverage Diff @@
## main #686 +/- ##
==========================================
- Coverage 93.77% 93.69% -0.09%
==========================================
Files 364 364
Lines 6536 6548 +12
==========================================
+ Hits 6129 6135 +6
- Misses 407 413 +6
Continue to review full report at Codecov.
|
|
Hey @rickychilcott. Yeah, this might work. It seems I haven't thought about this change as being a breaking change, but what you're saying makes sense. I'll check it out and merge this before Monday's release. |
Description
Pundit 2.2.0 changes the Module that is required to be included, which is a breaking change. Since Pundit 2.1.x is still very viable for most apps, support both options.
Checklist: