Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: some very used partials converted to view_components #706

Merged
merged 1 commit into from Feb 25, 2022

Conversation

adrianthedev
Copy link
Collaborator

@adrianthedev adrianthedev commented Feb 25, 2022

Description

Just a performance upgrade

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@codeclimate
Copy link

codeclimate bot commented Feb 25, 2022

Code Climate has analyzed commit 6c0f603 and detected 0 issues on this pull request.

View more on Code Climate.

@codecov
Copy link

codecov bot commented Feb 25, 2022

Codecov Report

Merging #706 (6c0f603) into main (d604d8d) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #706   +/-   ##
=======================================
  Coverage   94.18%   94.19%           
=======================================
  Files         366      369    +3     
  Lines        6759     6770   +11     
=======================================
+ Hits         6366     6377   +11     
  Misses        393      393           
Impacted Files Coverage Δ
app/components/avo/alert_component.rb 100.00% <100.00%> (ø)
app/components/avo/alerts_component.rb 100.00% <100.00%> (ø)
...pp/components/avo/turbo_frame_wrapper_component.rb 100.00% <100.00%> (ø)
app/helpers/avo/application_helper.rb 93.15% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d604d8d...6c0f603. Read the comment docs.

@adrianthedev adrianthedev merged commit ed3d2f3 into main Feb 25, 2022
@adrianthedev adrianthedev deleted the refactor/turbo-frame-wrapper-to-view-component branch February 25, 2022 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant