Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: authorization logic error #854

Merged
merged 2 commits into from Apr 18, 2022
Merged

Conversation

adrianthedev
Copy link
Collaborator

Description

Fixes #851

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@github-actions github-actions bot added the Fix label Apr 18, 2022
@codeclimate
Copy link

codeclimate bot commented Apr 18, 2022

Code Climate has analyzed commit b89eabd and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 1

View more on Code Climate.

@codecov
Copy link

codecov bot commented Apr 18, 2022

Codecov Report

Merging #854 (b89eabd) into main (d050b5d) will decrease coverage by 0.02%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##             main     #854      +/-   ##
==========================================
- Coverage   93.87%   93.85%   -0.03%     
==========================================
  Files         457      457              
  Lines        8311     8313       +2     
==========================================
  Hits         7802     7802              
- Misses        509      511       +2     
Impacted Files Coverage Δ
lib/avo/services/authorization_service.rb 80.95% <33.33%> (-2.66%) ⬇️
spec/system/avo/default_field_spec.rb 95.12% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d050b5d...b89eabd. Read the comment docs.

@adrianthedev adrianthedev merged commit 72d411a into main Apr 18, 2022
@adrianthedev adrianthedev deleted the fix/authorization-logic-error branch April 18, 2022 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Likely logic error in Avo::Services::AuthorizationService#authorize_action
1 participant