refactor: move fields logic to concern #915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| return matched_field[:class] if matched_field.present? && matched_field[:class].present? | ||
| end | ||
|
|
||
| def parse_symbol(field_name, as:, **args, &block) |
There was a problem hiding this comment.
Method parse_symbol has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
|
Code Climate has analyzed commit a1f1b61 and detected 1 issue on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
| return matched_field[:class] if matched_field.present? && matched_field[:class].present? | ||
| end | ||
|
|
||
| def parse_symbol(field_name, as:, **args, &block) |
There was a problem hiding this comment.
Method parse_symbol has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Codecov Report
@@ Coverage Diff @@
## main #915 +/- ##
==========================================
- Coverage 93.88% 93.86% -0.02%
==========================================
Files 483 483
Lines 9038 9050 +12
==========================================
+ Hits 8485 8495 +10
- Misses 553 555 +2
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some house-cleaning. We're moving some things to concerns.
Checklist: