env_process: add nested virtualization support to run tests in nested VMs #1947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balamuruhans
force-pushed
the
nest_env
branch
2 times, most recently
from
4ac7b59
to
79a5158
Compare
|
As the avocado-vt that is installed inside the guest needs the nested support, I tested it with my test branch, Below mentioned is the test results: Host:
L1 Guest: |
balamuruhans
force-pushed
the
nest_env
branch
3 times, most recently
from
3952d2a
to
486f2a1
Compare
|
@sathnaga @luckyh @vivianQizhu would you guys help for reviewing |
sathnaga
approved these changes
Feb 12, 2019
balamuruhans
force-pushed
the
nest_env
branch
2 times, most recently
from
6cb0867
to
1b116ce
Compare
sathnaga
reviewed
Jun 7, 2019
virttest/env_process.py
Outdated
| @@ -1123,16 +1146,33 @@ def preprocess(test, params, env): | |||
| testlist = [new_params.get("avocado_guest_vt_test", | |||
| "boot")] | |||
| avocadotestargs = new_params.get("avocado_guest_add_args", "") | |||
| # add nested-hv feature attribute to VM's libvirt xml | |||
| if new_params.get("vm_type") == "libvirt": | |||
There was a problem hiding this comment.
we can choose to use --virt-install extra-params aswell, if create_vm_libvirt param is set, so that we can avoid creating a vm at all to change.
There was a problem hiding this comment.
Thanks @sathnaga, I have taken care of the suggestion.
added 2 commits
August 20, 2019 14:42
… VMs This patch enables existing tests to be run on nested VMs to multilevels, is supports N * N * N VMs where multiple guests can be brought up and nested with multilevel and multiple VMs on every level. The params can be set to the granularity of any particular VM on any level. The point here is to dynamically calculate and distribute memory to higher level VMs based on the available memory in current level VM/host. It is not neccesary but it is required for VMs to run test seamlessly on positive scenarios, still negative scenarios can be tested by overriding the param to perform this distribution. We handle the test across all the VMs at all the Levels in linear way as parallelism from here will not have control on the test flow but configuring different testcases on different VMs at any level is possible. Parallel test scenarios can be added from testcase indeed. Signed-off-by: Balamuruhan S <bala24@linux.vnet.ibm.com>
This patch adds the support to run nested VMs in threads and pass on the params from one level to next level which means currently the tests in each level would run with the default params of the test but with this support user can pass the customised params specific to levels or specific to VMs in the levels while starting the tests. Also boot the VM with `cap-nested-hv=on` in qemu commandline to allow nested virtualization. Signed-off-by: Balamuruhan S <bala24@linux.vnet.ibm.com>
|
This pull request introduces 1 alert when merging 1d01b0d into 3f08daa - view on LGTM.com new alerts:
|
|
The warning is unrelated to the PR. |
sathnaga
reviewed
Aug 21, 2019
sathnaga
approved these changes
Aug 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch enables existing tests to be run on nested VMs to
multilevels, is supports N * N * N VMs where multiple guests
can be brought up and nested with multilevel and multiple VMs
on every level. The params can be set to the granularity of any
particular VM on any level.
The point here is to dynamically calculate and distribute memory to
higher level VMs based on the available memory in current level
VM/host. It is not neccesary but it is required for VMs to run
test seamlessly on positive scenarios, still negative scenarios
can be tested by overriding the param to perform this distribution.
We handle the test across all the VMs at all the Levels in linear
way as parallelism from here will not have control on the test
flow but configuring different testcases on different VMs at any
level is possible. Parallel test scenarios can be added from testcase
indeed.
Signed-off-by: Balamuruhan S bala24@linux.vnet.ibm.com