Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kernel_interface: handle invalid literal for int() #2128

Merged
merged 1 commit into from
Jul 5, 2019

Conversation

balamuruhans
Copy link
Member

Sys and proc interface can return value that may not be
type casted to int type, so return as string on receiving
ValueError.

Signed-off-by: Balamuruhan S bala24@linux.vnet.ibm.com

Copy link
Member

@sathnaga sathnaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, do we need str type case at all, just return the value incase of ValueError should work aswell right?

Sys and proc interface can return value that may not be
type casted to int type, so return as string on receiving
`ValueError`.

Signed-off-by: Balamuruhan S <bala24@linux.vnet.ibm.com>
@balamuruhans
Copy link
Member Author

@sathnaga made the changes as suggested

@sathnaga sathnaga merged commit e837ffb into avocado-framework:master Jul 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants