Assets: default asset name to empty string #4416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of allowing it to be given an explicit None. The problem with allowing None is that the name is given to Python's urlparse(), and it has the behavior of returning either a ParseResult or a ParseResultBytes depending on the input given. To prevent having to add further logic on a large part of the asset code, let's just normalize the input. Reference: https://docs.python.org/3/library/urllib.parse.html#urllib.parse.urlparse Signed-off-by: Cleber Rosa <crosa@redhat.com>
clebergnu
force-pushed
the
asset_none_parse_result_bytes
branch
from
6767467
to
229d64f
Compare
| @@ -62,7 +62,7 @@ def __init__(self, name, asset_hash=None, algorithm=None, locations=None, | |||
| :param expire: time in seconds for the asset to expire | |||
| :param metadata: metadata which will be saved inside metadata file | |||
| """ | |||
| self.name = name | |||
| self.name = name or '' | |||
There was a problem hiding this comment.
With a high-level look at the code, I think it will cause misbehavior in the Asset API. I'll do a more in-depth review and test on Monday.
|
Code Climate has analyzed commit 229d64f and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 70.3% (0.0% change). View more on Code Climate. |
willianrampazzo
approved these changes
Feb 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of allowing it to be given an explicit None. The problem with
allowing None is that the name is given to Python's urlparse(), and it
has the behavior of returning either a ParseResult or a
ParseResultBytes depending on the input given.
To prevent having to add further logic on a large part of the asset
code, let's just normalize the input.
Reference: https://docs.python.org/3/library/urllib.parse.html#urllib.parse.urlparse
Signed-off-by: Cleber Rosa crosa@redhat.com