Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assets: default asset name to empty string #4416

Merged
merged 1 commit into from Feb 23, 2021
Merged

Assets: default asset name to empty string #4416

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion avocado/utils/asset.py
View file
Open in desktop
Expand Up @@ -62,7 +62,7 @@ def __init__(self, name, asset_hash=None, algorithm=None, locations=None,
:param expire: time in seconds for the asset to expire
:param metadata: metadata which will be saved inside metadata file
"""
self.name = name
self.name = name or ''
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With a high-level look at the code, I think it will cause misbehavior in the Asset API. I'll do a more in-depth review and test on Monday.

self.asset_hash = asset_hash

if isinstance(locations, str):
Expand Down