Add support for localeOptions option: allow customization of i18n output #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! I'll prep a release |
avoidwork
added a commit
that referenced
this pull request
Sep 11, 2019
christopherscott
added a commit
to christopherscott/DefinitelyTyped
that referenced
this pull request
Sep 11, 2019
Related to: avoidwork/filesize.js#102 Updates the `Options` type to allow for an optional `localeOptions` object to be passed in. `NumberFormatOptions` is [provided by typescript](https://github.com/Microsoft/TypeScript/blob/master/src/lib/es5.d.ts#L4060).
christopherscott
added a commit
to christopherscott/DefinitelyTyped
that referenced
this pull request
Sep 11, 2019
Related to: avoidwork/filesize.js#102 Updates the `Options` type to allow for an optional `localeOptions` object to be passed in. `NumberFormatOptions` is [provided by typescript](https://github.com/Microsoft/TypeScript/blob/master/src/lib/es5.d.ts#L4060).
christopherscott
added a commit
to christopherscott/DefinitelyTyped
that referenced
this pull request
Sep 11, 2019
Related to: avoidwork/filesize.js#102 Updates the `Options` type to allow for an optional `localeOptions` object to be passed in. `NumberFormatOptions` is [provided by typescript](https://github.com/Microsoft/TypeScript/blob/master/src/lib/es5.d.ts#L4060).
Merged
9 tasks
orta
pushed a commit
to DefinitelyTyped/DefinitelyTyped
that referenced
this pull request
Sep 16, 2019
Related to: avoidwork/filesize.js#102 Updates the `Options` type to allow for an optional `localeOptions` object to be passed in. `NumberFormatOptions` is [provided by typescript](https://github.com/Microsoft/TypeScript/blob/master/src/lib/es5.d.ts#L4060).
pheromonez
pushed a commit
to class-clown/DefinitelyTyped
that referenced
this pull request
Sep 17, 2019
…ped#38309) Related to: avoidwork/filesize.js#102 Updates the `Options` type to allow for an optional `localeOptions` object to be passed in. `NumberFormatOptions` is [provided by typescript](https://github.com/Microsoft/TypeScript/blob/master/src/lib/es5.d.ts#L4060).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for passing an additional parameter
localeOptionsthat is used when an explicitlocaleis passed to allow for further customization of the output. Defaults to{}.This is particularly useful for places where filesize is highly dynamic/animated and there is a desire to enforce a number of fixed digits, even in cases where the decimal would be zero:
Example without (notice the left-shift of the digits when no zero decimal):
Example with:
Usage:
The options are from ECMA-402, and are documented on MDN.