Fixing assignment of last & adding test

avoidwork · Dec 8, 2018 · 12d7d06 · 12d7d06
1 parent 8b6719a
commit 12d7d06
Show file tree

Hide file tree

Showing 7 changed files with 133 additions and 73 deletions.
diff --git a/lib/tiny-lru.js b/lib/tiny-lru.js
@@ -5,7 +5,7 @@
  * @copyright 2018
  * @license BSD-3-Clause
  * @link https://github.com/avoidwork/tiny-lru
- * @version 4.0.5
+ * @version 4.0.6
  */
 "use strict";
 
@@ -141,23 +141,23 @@
 				item.value = value;
 
 				if (this.first !== key) {
-					const left = item.next,
-						right = item.previous;
+					const n = item.next,
+						p = item.previous;
 
 					item.next = empty;
 					item.previous = this.first;
 					link(this.cache[this.first], key, "next", "previous");
 
-					if (left !== empty && left !== this.first) {
-						if (right !== empty) {
-							this.cache[right].next = left;
+					if (n !== empty && n !== this.first) {
+						if (p !== empty) {
+							this.cache[p].next = n;
 						}
 
-						this.cache[left].previous = right;
+						this.cache[n].previous = p;
 					}
 
 					if (this.last === key) {
-						this.last = item.previous;
+						this.last = n;
 					}
 				}
 			} else {

diff --git a/lib/tiny-lru.min.js b/lib/tiny-lru.min.js
diff --git a/lib/tiny-lru.min.js.map b/lib/tiny-lru.min.js.map
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,7 +1,7 @@
 {
   "name": "tiny-lru",
   "description": "Tiny LRU cache for Client or Server",
-  "version": "4.0.5",
+  "version": "4.0.6",
   "homepage": "https://github.com/avoidwork/tiny-lru",
   "author": "Jason Mulligan <jason.mulligan@avoidwork.com>",
   "repository": {

diff --git a/src/lru.js b/src/lru.js
@@ -109,23 +109,23 @@
 				item.value = value;
 
 				if (this.first !== key) {
-					const left = item.next,
-						right = item.previous;
+					const n = item.next,
+						p = item.previous;
 
 					item.next = empty;
 					item.previous = this.first;
 					link(this.cache[this.first], key, "next", "previous");
 
-					if (left !== empty && left !== this.first) {
-						if (right !== empty) {
-							this.cache[right].next = left;
+					if (n !== empty && n !== this.first) {
+						if (p !== empty) {
+							this.cache[p].next = n;
 						}
 
-						this.cache[left].previous = right;
+						this.cache[n].previous = p;
 					}
 
 					if (this.last === key) {
-						this.last = item.previous;
+						this.last = n;
 					}
 				}
 			} else {