Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the existing constants instead of hardcoding limits #60

Merged
merged 2 commits into from
Apr 28, 2023
Merged

Use the existing constants instead of hardcoding limits #60

merged 2 commits into from
Apr 28, 2023

Conversation

Croebh
Copy link
Collaborator

@Croebh Croebh commented Apr 28, 2023

Summary

Various api calls were using hard coded limits instead of the existing constants. This particularly affected Snippets, which had a general limit of 5,000 characters but was hard coded to only allow 2,000 characters.

Checklist

PR Type

  • This PR is a code change that implements a feature request.
  • This PR fixes an issue.
  • This PR adds a new feature that is not an open feature request.
  • This PR is not a code change (e.g. documentation, README, ...)

Other

  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • If code changes were made then they have been tested.
  • I have updated the documentation to reflect the changes.

@Croebh Croebh requested a review from zhudotexe April 28, 2023 00:29
@Croebh Croebh merged commit c695185 into master Apr 28, 2023
@Croebh Croebh deleted the remove_magic_numbers branch April 28, 2023 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhudotexe zhudotexe Awaiting requested review from zhudotexe

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Croebh