Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AFR-580 More arguments to !a add (-criton, -phrase, -thumb, -title), along with adding the first 3 to the dashboard automation #1163

Closed
taine-bot opened this issue Jul 19, 2020 · 6 comments · Fixed by #1320
Labels
featurereq P3: Medium Issues that will be implemented eventually.

Comments

@taine-bot
Copy link
Collaborator

taine-bot commented Jul 19, 2020

Feature Request: More arguments to !a add (-criton, -phrase, -thumb, -title), along with adding the first 3 to the dashboard automation
Who would use it? -criton is good for champion fighters or certain magical weapons, -title would be good to replicate the way it's handled on the dashboard while we don't have -json yet, -thumb for custom images for more flavor, -phrase for cool flavor text
What part of the bot? !a add
How would it work? on !a add, just stores the information for the attack. On the dashboard, add new portions to the dropdown menu to put a link, text etc.
Why should this be added? Just for more control on what can be done on Avrae side with !a add, especially while we wait for -json, along with make it so we don't need as many snippets, so there's less players would need to remember to add to an attack

  • Riptidecord#7191

Upvote - Riptidecord#7191

Upvote - spamandtuna#9657

Upvote - R to the Ichie#6193

Upvote - Dr Turtle#1771

Upvote - Kortar#9227

Upvote - Zekl#1505

Upvote - silverbass#2407

Upvote - mellowmelody#5842

Upvote - TheReverendB#1377

Votes: +9 / -0

@Infinidoge
Copy link
Contributor

Some more that might be worth considering (that are not listed in the FR):

  • -f
  • adv/dis (This is almost certainly not needed, but who knows)
  • crit/max/magical
  • snippets? (Poor person's CC deduction and code execution?)

@zhudotexe
Copy link
Collaborator

zhudotexe commented Jul 20, 2020

  • -criton - yes
  • -phrase - yes
  • -thumb - yes
  • -c - probably
  • -title - maybe - this is what verb is kind of for
  • -f - maybe
  • adv/dis - what's the use case for this?
  • crit/max/magical - what's the use case for this? all of these can be accomplished by modifying the automation
  • snippets - no
  • -verb
  • proper

@taine-bot
Copy link
Collaborator Author

Note - Kortar#9227

adv/dis Might have an Official case, but I've seen a few Items that give Adv or Dis to all the rolls made with it

@taine-bot
Copy link
Collaborator Author

Note - silverbass#2407

-c [damage] for vicious weapons

@zhudotexe zhudotexe added the P3: Medium Issues that will be implemented eventually. label Jul 27, 2020
@Croebh
Copy link
Collaborator

Croebh commented Oct 2, 2020

-verb and proper too

@taine-bot
Copy link
Collaborator Author

Note - zhu.exe#4211

Resolved - Patched in build 1537: v2.6.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
featurereq P3: Medium Issues that will be implemented eventually.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants