Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print HAVE_LIBREADLINE status #1184

Merged
merged 2 commits into from
Nov 22, 2022
Merged

Conversation

mcuee
Copy link
Collaborator

@mcuee mcuee commented Nov 19, 2022

Readline is now required for better functionality when available. It is better to print out the status during CMake configure stage.

@mcuee mcuee added the enhancement New feature or request label Nov 19, 2022
@MCUdude
Copy link
Collaborator

MCUdude commented Nov 19, 2022

Thanks for the PR!
Maybe you could add this to configure.ac as well?

@mcuee
Copy link
Collaborator Author

mcuee commented Nov 20, 2022

Thanks for the PR! Maybe you could add this to configure.ac as well?

Auto-tools are more difficult for me, but I will try.

@mcuee
Copy link
Collaborator Author

mcuee commented Nov 20, 2022

@MCUdude
It turns out the change to configure.ac is also simple. Please give it a try.

@mcuee
Copy link
Collaborator Author

mcuee commented Nov 21, 2022

Take note thie PR will still treat macOS system bundled libedit as having Readline. It can be safely merged even after the merge of PR #1185.

@stefanrueger stefanrueger merged commit ef824d4 into avrdudes:main Nov 22, 2022
@mcuee mcuee deleted the cmake_print_readline branch December 27, 2022 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants