Add a workaround for issue #1173 #1185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The readline compat layer for libedit which otherwise provides native readline functionality in NetBSD and MacOS appears to have a bug that causes subsequent prompts to be delayed until another line is being processed. Re-installing the callback over and over again works around that, and does not seem to harm with GNU libreadline.
|
Tested to be good under macOS (Mac Mini M1) with libedit. |
|
Thanks for the PR! Works perfectly with (legacy) macOS 10.14 libedit |
|
@mcuee do you think the build instructions for macOS should be updated? The user doesn't really need to install libreadline anymore |
Wiki updated. |
mcuee
added a commit
to mcuee/avrdude
that referenced
this pull request
Nov 21, 2022
This commmit updates build.sh to remove the needs of GNU Readline under macOS, after the merge of PR avrdudes#1185.
mcuee
added a commit
to mcuee/avrdude
that referenced
this pull request
Nov 21, 2022
This commmit updates github action to remove the needs of GNU Readline under macOS, after the merge of PR avrdudes#1185.
This was referenced Nov 21, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The readline compat layer for libedit which otherwise provides native readline functionality in NetBSD and MacOS appears to have a bug that causes subsequent prompts to be delayed until another line is being processed.
Re-installing the callback over and over again works around that, and does not seem to harm with GNU libreadline.